provider/aws: Add multi-region option to cloudtrail #4939
Conversation
| @@ -73,6 +78,9 @@ func resourceAwsCloudTrailCreate(d *schema.ResourceData, meta interface{}) error | |||
| if v, ok := d.GetOk("include_global_service_events"); ok { | |||
| input.IncludeGlobalServiceEvents = aws.Bool(v.(bool)) | |||
| } | |||
| if v, ok := d.GetOk("is_multi_region_trail"); ok { | |||
| input.IncludeGlobalServiceEvents = aws.Bool(v.(bool)) | |||
There was a problem hiding this comment.
Is this a copy paste error?
|
There is a few (IMO small) things to fix which I mentioned above, otherwise it's looking good @Bowbaq |
radeksimko
added
the
waiting-response
|
@radeksimko will fix, is there a way to make the acceptance tests use the credentials in |
I'm afraid there isn't atm. I was also thinking of switching from ENV variables to a specific profile name, now when it's supported. I created a separate issue to discuss this: #5019 |
radeksimko
removed
the
waiting-response
provider/aws: Add multi-region option to cloudtrail
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Adds the option to enable a multi-region trail.